Fixed *args and **kwargs handling in the functools overlay #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/821665368
branch
2 times, most recently
from
73a4d38 to
b4a8a10
Compare
pytype is sometimes able to convert args/kwargs to positional/keyword arguments. The functools overlay did not account for that prior to this change, and ended up passing the same arguments twice! See added test case for a minimal repro. PiperOrigin-RevId: 822295276
copybara-service
bot
force-pushed
the
cl/821665368
branch
from
b4a8a10 to
68ece50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed *args and **kwargs handling in the functools overlay
pytype is sometimes able to convert args/kwargs to positional/keyword arguments.
The functools overlay did not account for that prior to this change, and ended
up passing the same arguments twice!
See added test case for a minimal repro.